Support inserted plausible snippet from website config #13524
Merged
Conversation
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Member
|
I like this balance: a dedicated key gives us an obvious place to document it (alongside |
Member
Author
|
Great! I'll make a PR to the doc too. |
Member
Author
|
We could also do this to allow less ugly configuration in addition of |
32f825a to
c5edb6f
Compare
Member
Author
|
@cscheid I have added the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to have a simple built-in support for a
plausible-analyticskey, like we have forgoogle-analytics.I say simple because what this does it only accepting the HTML snippet that a user is supposed to get from its plausible dashboard: https://plausible.io/docs/plausible-script
It seems there are ways to use a generic
https://plausible.io/js/script.jsand pass domain as attributes. However, this is not documented and could be harder to maintain.Also the user workflow will always be to go to its plausible dashboard to activate, and so copy pasting the snippet is easy enough.
More complex config would allow something like
google-analyticsbut again, not well documented and so probably not easy to maintain and test.